Re: [Xen-devel] [PATCH] tools/libxc: Fix domid parameter types

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Oct 11, 2017 at 10:52:42AM +0100, Andrew Cooper wrote:
> On 11/10/17 10:51, Ian Jackson wrote:
> > Andrew Cooper writes ("[PATCH] tools/libxc: Fix domid parameter types"):
> >> Mixed throughout libxc are uint32_t, int, and domid_t for domid parameters.
> >> With a signed type, and an explicitly 16-bit type, it is exceedingly 
> >> difficult
> >> to construct an INVALID_DOMID constant which works with all of them.  (The
> >> main problem being that domid_t gets unconditionally zero extended when
> >> promoted to int for arithmatic.)
> >>
> >> Libxl uses uint32_t consistently everywhere, so alter libxc to match.
> > I like this plan.  But I think this comes a bit late for 4.10 ?
> 
> I'm sorry for it being late, but it is blocking my other series to fix
> gnttab construction in the domain builder, which really is 4.10 material.
> 

OK. I don't want to block the more important work.

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel