Re: [Xen-devel] [PATCH v10 04/11] public: xen.h: add definitions for UUID handling

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 11.10.17 at 13:57, <volodymyr_babchuk@xxxxxxxx> wrote:
> +/* Compound literals are supported in C99 and later. */
> +#if (defined (__STDC_VERSION__) && __STDC_VERSION__ >= 199901L) ||      \
> +    defined (__GNUC__)

Strictly speaking the comment above is now stale.

Also please don't put a space between "defined" and the opening
parenthesis. If you check, the only two other such instances
throughout the public headers are two ARM conditionals.

And then the whole thing can be made fit on one line:

#if defined(__STDC_VERSION__) ? __STDC_VERSION__ >= 199901L : defined(__GNUC__)

> +#define XEN_DEFINE_UUID(a, b, c, d, e1, e2, e3, e4, e5, e6)             \
> +    ((xen_uuid_t)XEN_DEFINE_UUID_(a, b, c, d, e1, e2, e3, e4, e5, e6))
> +#else
> +#define XEN_DEFINE_UUID(a, b, c, d, e1, e2, e3, e4, e5, e6)             \
> +    XEN_DEFINE_UUID_(a, b, c, d, e1, e2, e3, e4, e5, e6)
> +#endif /* defined (__STDC_VERSION__) && __STDC_VERSION__ >= 199901L */

Same for the comment here. I'd suggest either dropping it altogether
or shortening it (e.g. /* __STDC_VERSION__ / __GNUC__ */)

All of these adjustments ought to be doable while committing.
With them done
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel