Re: [Xen-devel] [PATCH for-4.10] xen: Fix XEN_DMOP_remote_shutdown return value

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Andrew Cooper writes ("Re: [PATCH for-4.10] xen: Fix XEN_DMOP_remote_shutdown 
return value"):
> On 11/10/17 16:41, Ross Lagerwall wrote:
> > Return 0 to indicate success rather than whatever rc was previously set
> > to (-EINVAL).
> >
> > Signed-off-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
> > ---
> >  xen/arch/x86/hvm/dm.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/xen/arch/x86/hvm/dm.c b/xen/arch/x86/hvm/dm.c
> > index 82addea..32ade95 100644
> > --- a/xen/arch/x86/hvm/dm.c
> > +++ b/xen/arch/x86/hvm/dm.c
> > @@ -636,6 +636,7 @@ static int dm_op(const struct dmop_args *op_args)
> >              &op.u.remote_shutdown;
> >  
> >          domain_shutdown(d, data->reason);
> > +        rc = 0;
> 
> Ideally with a newline here (can be fixed on commit).

Thanks to Ross for spotting this, and to whoever committed it so
speedily.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel