Re: [Xen-devel] [PATCH 1/2] libxl: dm_restrict: Move to domain_build_info

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Thu, Oct 12, 2017 at 11:21:06AM +0000, Ian Jackson wrote:
> Right now, this is broken because libxl__build_device_model_args_new
> is used also for the qemu run for pv guests for qdisk devices, pvfb,
> etc.
> 
> We can either make this option properly HVM-specific, or make it
> generic.
> 
> In principle it is a reasonable request, to make the PV qemu
> deprivileged (even though it is not likely to be implemented any time
> soon).  So make this option generic.
> 
> We retain the name "device model" even though it is arguably
> inaccurate, because the xl docs already say, for example
>   For a PV guest a device-model is sometimes used to provide backends
>   for certain PV devices
> 
> The documentation patch here is pure code motion.  For ease of review
> we will fix up the docs, so the wording to be right for the new
> context, in the next patch.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> Reported-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> ---
>  docs/man/xl.cfg.pod.5.in    | 198 
> ++++++++++++++++++++++----------------------
>  tools/libxl/libxl_create.c  |   2 +-
>  tools/libxl/libxl_dm.c      |   6 +-
>  tools/libxl/libxl_types.idl |   2 +-

This is at least missing a change to xl_parse.c AFAICT.

The rest LGTM.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel