[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [RFC v2 5/7] acpi:arm64: Add support for parsing IORT table



Hi Sameer,

On 21/09/17 01:37, Sameer Goel wrote:
@@ -583,14 +631,13 @@ const struct iommu_ops *iort_iommu_configure(struct 
device *dev)
        u32 streamid = 0;
if (dev_is_pci(dev)) {
-               struct pci_bus *bus = to_pci_dev(dev)->bus;
+               struct pci_dev *pci_device = to_pci_dev(dev);
                u32 rid;
- pci_for_each_dma_alias(to_pci_dev(dev), __get_pci_rid,
-                                      &rid);
+               rid = PCI_BDF2(pci_device->bus, pci_device->devfn);

I forgot to answer on this bit. On the previous it was mentioned this was wrong, but still there.

Whilst I can understand that implementing pci_for_each_dma_alias could require some work in Xen, I don't want to see rid = PCI_BDF2(...) spreading the code. So what's the plan?

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.