Re: [Xen-devel] [PATCH 1/3] x86/dom0: use dom0_paging_pages to account for the memory used by IOMMU pt

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 29.09.17 at 13:25, <roger.pau@xxxxxxxxxx> wrote:
> Instead of open coding a calculation for it.

But how well do the two calculation results match up? In particular
I doubt the IOMMU page table reservation needs is vCPU count
dependent.

> --- a/xen/arch/x86/dom0_build.c
> +++ b/xen/arch/x86/dom0_build.c
> @@ -254,14 +254,9 @@ unsigned long __init dom0_compute_nr_pages(
>      if ( is_pv_32bit_domain(d) )
>          avail -= d->max_vcpus - 1;
>  
> -    /* Reserve memory for iommu_dom0_init() (rough estimate). */
> +    /* Reserve memory for iommu_dom0_init(). */

Is the new result any less rough an estimate compared to what
we've been using so far? Quite the opposite, I would guess.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel