Re: [Xen-devel] [PATCH 3/3] x86/dom0: simplify dom0_compute_nr_pages

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 29.09.17 at 13:25, <roger.pau@xxxxxxxxxx> wrote:
> Remove the loop in dom0_compute_nr_pages.
> 
> This is a non-functional change for PV domains, that would always have
> need_paging set to false, and thus only did a single loop iteration.
> 
> For a PVH Dom0 the loop is not needed anymore, since the amount of
> memory needed for paging no longer depends on the amount of memory
> assigned to Dom0, but rather on the value of max_pdx. Hence it can be
> removed from the amount of available memory before doing the
> accounting of memory assigned to Dom0.

Which, as said in reply to patch 2, may be slightly or meaningfully
wrong. If both earlier patches were proven to be fine, the one here
can have my ack.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel