Re: [Xen-devel] [PATCH v4 08/12] fuzz/x86_emulate: Move all state into fuzz_state

[George Dunlap <george.dunlap@xxxxxxxxxx>]

On 10/13/2017 10:54 AM, Jan Beulich wrote:
>>>> On 13.10.17 at 11:22, <george.dunlap@xxxxxxxxxx> wrote:
>> On 10/12/2017 04:16 PM, Jan Beulich wrote:
>>>>>> On 11.10.17 at 19:52, <george.dunlap@xxxxxxxxxx> wrote:
>>>> @@ -761,12 +757,11 @@ static void disable_hooks(struct x86_emulate_ctxt 
>>>> *ctxt)
>>>>  static void sanitize_input(struct x86_emulate_ctxt *ctxt)
>>>>  {
>>>>      struct fuzz_state *s = ctxt->data;
>>>> -    struct fuzz_corpus *c = s->corpus;
>>>> -    struct cpu_user_regs *regs = &c->regs;
>>>> -    unsigned long bitmap = c->options;
>>>> +    struct cpu_user_regs *regs = ctxt->regs;
>>>> +    unsigned long bitmap = s->options;
>>>>  
>>>>      /* Some hooks can't be disabled. */
>>>> -    c->options &= ~((1<<HOOK_read)|(1<<HOOK_insn_fetch));
>>>> +    s->options &= ~((1<<HOOK_read)|(1<<HOOK_insn_fetch));
>>>
>>> Mind adding the missing blanks here while you touch this?
>>
>> Like this?
>>
>>     s->options &= ~((1<<HOOK_read) | (1<<HOOK_insn_fetch));
> 
> Even farther (at the same time adding the missing number suffixes):
> 
>     s->options &= ~((1UL << HOOK_read) | (1UL << HOOK_insn_fetch));

Got it.  (I was actually trying to verify the 'snuggly' outer braces,
but missed spaces around the '<<'s).

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel