Re: [Xen-devel] [PATCH v2] x86/hvm: Add MSR old value

[Tamas K Lengyel <tamas@xxxxxxxxxxxxx>]

On Fri, Oct 13, 2017 at 9:50 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>> On 13.10.17 at 14:50, <aisaila@xxxxxxxxxxxxxxx> wrote:
>> This patch adds the old value param and the onchangeonly option
>> to the VM_EVENT_REASON_MOV_TO_MSR event.
>>
>> The param was added to the vm_event_mov_to_msr struct and to the
>> hvm_monitor_msr function. Finally I've changed the bool_t param
>> to a bool for the hvm_msr_write_intercept function.
>>
>> Signed-off-by: Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>
>> Acked-by: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
>
> I think this should have been dropped with a bug having been fixed
> (for only cosmetic changes it would be fine to keep). For the bits
> where it's applicable
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Indeed. It's fine for now, my ack still stands.

Thanks,
Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel