Re: [Xen-devel] [PATCH 2/2] x86/boot: rename send_chr to print_err

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 13.10.17 at 18:07, <cardoe@xxxxxxxxxx> wrote:
> On 10/13/17 2:40 AM, Jan Beulich wrote:
>>>>> On 12.10.17 at 22:56, <andrew.cooper3@xxxxxxxxxx> wrote:
>>> On 12/10/2017 21:50, Doug Goldstein wrote:
>>>> From: David Esler <drumandstrum@xxxxxxxxx>
>>>>
>>>> The send_chr function sends an entire C-string and not one character and
>>>> doesn't necessarily just send it over the serial UART anymore so rename
>>>> it to print_err so that its closer in name to what it does.
>>>>
>>>> Reviewed-by: Doug Goldstein <cardoe@xxxxxxxxxx>
>>>> Signed-off-by: David Esler <drumandstrum@xxxxxxxxx>
>>>
>>> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>>>
>>> This should also be included in 4.10 IMO.
>> 
>> I'm not convinced - this is merely a cleanup style patch, the more
>> that the label really serves dual purpose and hence the original
>> name isn't all that wrong anyway.
> 
> I purposefully broke it out so that it could be discussed. Prior to the
> commit I referenced in patch 1 the function sent out a character. Now it
> requires the supplied data to be a C-string (NULL terminated) so I would
> hope that you could agree that at else the "chr" part of "send_chr" is
> incorrect and should likely be "str" or "err".
> 
> But again this patch isn't really important its more to try to make the
> label match the behavior of the code below the label and if its unwanted
> then it can be dropped.

Oh, in case my earlier reply was ambiguous: I didn't mean to
object to the patch. I'm just unconvinced it should go into 4.10.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel