Re: [Xen-devel] libxl/xenconsole: vpl011: Fix hex to dec conversion of vuart_gfn in libxl__device_vuart_add

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 16.10.17 at 11:02, <bhupinder.thakur@xxxxxxxxxx> wrote:
>  static int console_create_ring(struct console *con)
>  {
> -     int err, remote_port, ring_ref, rc;
> +     int err, remote_port, rc;
> +     xen_pfn_t ring_ref;
>       char *type, path[PATH_MAX];
>       struct domain *dom = con->d;
>  
>       err = xs_gather(xs, con->xspath,
> -                     "ring-ref", "%u", &ring_ref,
> +                     "ring-ref", "%i", &ring_ref,

How would you gather a 64-bit value using %i without any length
modifier? With just %i you're even going to use partially initialized
data, so unless somewhere else the upper 32 bits got clipped off
again the console wouldn't work anymore.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel