Re: [Xen-devel] [RFC 3/4] arm: tee: add OP-TEE header files

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi,

On 17/10/17 17:24, Volodymyr Babchuk wrote:
> On Mon, Oct 16, 2017 at 03:04:44PM +0100, Julien Grall wrote:
> > Hi Volodymyr,
> Hi Julien,
>
> > On 11/10/17 20:01, Volodymyr Babchuk wrote:
> > > This header files describe protocol between OP-TEE and OP-TEE client
> > > driver in Linux. They are needed for upcomient OP-TEE mediator, which
> > > is added in the next patch.
> > > Reason to add those headers in separate patch is to ease up review.
> > > Those files were taken from linux tree (drivers/tee/optee/) and mangled
> > > a bit to compile with XEN.
> > >
> > > Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
> > > ---
> > >   xen/arch/arm/tee/optee_msg.h | 444 +++++++++++++++++++++++++++++++++++++++++
> > >   xen/arch/arm/tee/optee_smc.h | 457 +++++++++++++++++++++++++++++++++++++++++++
> > Headers should go in include/asm-arm/tee and not arch/arm.
> This headers are used only by optee.c in the same folder. Do I need to make
> them public?
They are not going to be public, just internal to Xen. But not in 
arch/arm, I know we did in some occasions but I would rather keep all 
the headers in include/asm-arm.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel