Re: [Xen-devel] [PATCH] tools: libxendevicemodel: Restore symbol versions for 1.0

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 17/10/17 18:06, Wei Liu wrote:
> On Tue, Oct 17, 2017 at 06:05:35PM +0100, Ian Jackson wrote:
>> In 1462f9ea8f4219d520a530787b80c986e050aa98
>> "tools: libxendevicemodel: Provide xendevicemodel_shutdown"
>> we added a new version 1.1 to the symbol map and simply abolished
>> the old one.  That is quite wrong.
>>
>> Instead, we should have left the 1.0 map alone and added a new version
>> which simply adds the new symbol.
>>
>> Fix this.
>>
>> Reported-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
>> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

CC'ing Julien for a release ack, as this is a blocker (due to regressing
the xendevicemodel ABI from Xen 4.9)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel