Re: [Xen-devel] [PATCH v8 02/16] Rename PSR sysctl/domctl interfaces and xsm policy to make them be general

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Oct 18, 2017 at 08:14:20AM -0600, Jan Beulich wrote:
> >>> On 16.10.17 at 05:04, <yi.y.sun@xxxxxxxxxxxxxxx> wrote:
> > v7:
> >     - add single trailing underscore for internal variabled in macro.
> >       (suggested by Jan Beulich)
> >     - add parentheses for input parameters of marcro.
> >       (suggested by Jan Beulich)
> >     - adjust the postion of macro.
> >       (suggested by Jan Beulich)
> > v6:
> >     - move macro definition into the function and undefine it after use.
> >       (suggested by Roger Pau Monné)
> >     - do not bump sysctl version because it has been bumped for 4.10.
> >       (suggested by Roger Pau Monné)
> 
> I was about to indicate that this needs resurrecting now that the
> series has missed 4.10, but then again, Wei, ...
> 
> > v1:
> >     - add description about what to be changed in commit message.
> >       (suggested by Wei Liu)
> >     - bump sysctl/domctl version numbers.
> >       (suggested by Wei Liu)
> 
> ... I wonder why you did ask for it in the first place. There are
> no binary incompatible changes, and those numbers changing
> doesn't have any advantage for code no longer compiling - that
> would need to be adjusted to the new naming anyway.
> 

If the interface is changed (code- and ABI-wise) it is always safe(r) to
also bump the version number. We have a lot of numbers to burn -- that
would save you from reasoning (like you did here).

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel