Re: [Xen-devel] [PATCH v2 1/2] x86/boot: fix early error display

[Doug Goldstein <cardoe@xxxxxxxxxx>]

On 10/18/17 4:50 AM, Jan Beulich wrote:
>>>> On 17.10.17 at 23:41, <cardoe@xxxxxxxxxx> wrote:
>> From: David Esler <drumandstrum@xxxxxxxxx>
>>
>> In 9180f5365524 a change was made to the send_chr function to take in
>> C-strings and print out a character at a time until a NULL was
>> encountered. However there is no code to increment the current character
>> position resulting in an endless loop of the first character. This adds
>> a simple increment.
> 
> This description is not accurate (it should have changed together with
> the change to how you fix the issue) - with VGA the increment does
> happen. Hence "display" in the title is perhaps also at least misleading.
> I would be fine to adjust both while committing (and then adding my
> R-b), but feel free to propose an alternative.

David and I are both ok with you changing the wording as necessary. I
apologize for not updating the commit message.

-- 
Doug Goldstein

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel