Re: [Xen-devel] [OSSTEST PATCH 13/16] ts-debian-hvm-install: disable new nic naming scheme

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Wei Liu writes ("[OSSTEST PATCH 13/16] ts-debian-hvm-install: disable new nic 
naming scheme"):
> This is required to fix nested hvm test. The L1 host is installed by
> this script. We want the L1 host to not use the new nic naming scheme.

The principle is fine.

> +    # Do not use "Predictable Network Interface Names" -- this can break
> +    # nested HVM tests.
> +    # 
> https://www.freedesktop.org/wiki/Software/systemd/PredictableNetworkInterfaceNames/
> +    #
> +    # See also
> +    # https://www.debian.org/releases/stretch/example-preseed.txt
> +    my $netifnames = "";
> +    $netifnames = "\nd-i debian-installer/add-kernel-opts string 
> net.ifnames=0\n"
> +        if $ho->{Suite} =~ m/stretch/;

Please use a <<END here document.  In fact, I think you should copy
the style seen elsewhere nearby, so something like

       $preseed_file .= <<END if $ho->{Suite}....
  d-i debian... etc. etc.
  END

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel