[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v12 26/33] HostDB: introduce set_property



Roger Pau Monne writes ("[PATCH v12 26/33] HostDB: introduce set_property"):
> And provide a helper in TestSupport to use it. This allows osstest to
> set host properties from test script themselves (instead of using
> the mg-hosts clu).
> 
> Note that the setting of host properties is limited to flights with
> intended blessing real, and it will fail for any other blessing.
...
> +    die "Attempting to modify host props with blessing $blessing != real"
> +        if $blessing ne "real";

Thanks.  You should write "intended blessing" in the commit message
and error message, since there is also a current blessing etc.

With that changed,

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>


Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.