Re: [Xen-devel] [PATCH v7] x86/altp2m: Added xc_altp2m_set_mem_access_multi()

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Oct 20, 2017 at 07:32:50PM +0300, Razvan Cojocaru wrote:
> On 10/20/2017 07:15 PM, Wei Liu wrote:
> > On Mon, Oct 16, 2017 at 08:07:41PM +0300, Petre Pircalabu wrote:
> >> From: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
> >>
> >> For the default EPT view we have xc_set_mem_access_multi(), which
> >> is able to set an array of pages to an array of access rights with
> >> a single hypercall. However, this functionality was lacking for the
> >> altp2m subsystem, which could only set page restrictions for one
> >> page at a time. This patch addresses the gap.
> >>
> >> HVMOP_altp2m_set_mem_access_multi has been added as a HVMOP (as opposed to 
> >> a
> >> DOMCTL) for consistency with its HVMOP_altp2m_set_mem_access counterpart 
> >> (and
> >> hence with the original altp2m design, where domains are allowed - with the
> >> proper altp2m access rights - to alter these settings), in the absence of 
> >> an
> >> official position on the issue from the original altp2m designers.
> >>
> >> Signed-off-by: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
> >> Signed-off-by: Petre Pircalabu <ppircalabu@xxxxxxxxxxxxxxx>
> >>
> > 
> > The title is a bit misleading -- this patch actually contains changes to
> > hypervisor as well.
> 
> Sorry, I have assumed that the hypervisor changes are implied.

And to expound my thought on this -- change in hypervisor is not
implied. We have had cases in which only toolstack change was needed
because hypervisor code was already there. Getting the title correct
will help reviewers identify patches they need to review.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel