Re: [Xen-devel] [PATCH v5.1 7/8] os-posix: Provide new -runas <uid>:<gid> facility

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Anthony PERARD writes ("Re: [PATCH v5.1 7/8] os-posix: Provide new -runas 
<uid>:<gid> facility"):
> On Fri, Oct 20, 2017 at 02:38:21PM +0100, Ian Jackson wrote:
> > +static bool os_parse_runas_uid_gid(const char *optarg)
...
> > +    errno = 0;
> > +    lv = strtoul(optarg, &ep, 0); /* can't qemu_strtoul, want *ep==':' */
> 
> Should strtoul base be 10? If that matter.

If someone wants to write uids in hex then I don't see a reason to
stop them...

> > -        if (!user_pwd) {
> > -            fprintf(stderr, "User \"%s\" doesn't exist\n", optarg);
> > +        if (!user_pwd && !os_parse_runas_uid_gid(optarg)) {
> > +            fprintf(stderr,
> > +                    "User \"%s\" doesn't exist (and is not <uid>.<gid>)\n",
> 
> The error message have not been update, I think it should be <uid>:<gid>

Oops.

> With the error message fix:
> Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel