Re: [Xen-devel] [PATCH V3 5/29] tools/libacpi: Add new fields in acpi_config for DMAR table

[Lan Tianyu <tianyu.lan@xxxxxxxxx>]

On 2017年10月19日 16:40, Roger Pau Monné wrote:
> On Thu, Oct 19, 2017 at 04:09:02PM +0800, Lan Tianyu wrote:
>> On 2017年10月18日 23:12, Roger Pau Monné wrote:
>>>> diff --git a/tools/libacpi/libacpi.h b/tools/libacpi/libacpi.h
>>>> index a2efd23..fdd6a78 100644
>>>> --- a/tools/libacpi/libacpi.h
>>>> +++ b/tools/libacpi/libacpi.h
>>>> @@ -20,6 +20,8 @@
>>>>  #ifndef __LIBACPI_H__
>>>>  #define __LIBACPI_H__
>>>>  
>>>> +#include <stdbool.h>
>>>
>>> I'm quite sure you shouldn't add this here, see how headers are added
>>> using LIBACPI_STDUTILS.
>>>
>>
>> We may replace bool with uint8_t xxx:1 to avoid introduce new head file.
> 
> Did you check whether including stdbool is actually required? AFAICT
> hvmloader util.h already includes it, and you would only have to
> introduce it in libxl if it's not there yet.
> 

Yes, you are right. stdbool.h has introduced in both libxl(libxl.h) and
hvmloader(util.h). We just need to adjust include order.

-- 
Best regards
Tianyu Lan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel