Re: [Xen-devel] [PATCH v2] scripts: introduce a script for build test

[George Dunlap <george.dunlap@xxxxxxxxxx>]

On 10/25/2017 04:27 PM, Wei Liu wrote:
> On Wed, Oct 25, 2017 at 04:25:21PM +0100, Ian Jackson wrote:
>> Wei Liu writes ("Re: [PATCH v2] scripts: introduce a script for build test"):
>>> On Tue, Oct 24, 2017 at 02:38:39PM +0100, Ian Jackson wrote:
>>>> Anthony PERARD writes ("Re: [PATCH v2] scripts: introduce a script for 
>>>> build test"):
>>>>> That feels wrong. How do I run the same exact command at the default
>>>>> one, but with -j8 instead of -j4?
>>>>
>>>>  .../build-test sh -ec make -j4 distclean && ./configure && make -j4
>>>>
>>>> But I think Anthony has a point.  The clean should 1. be git-clean,
>>>> not make distclean 2. be run anyway.
>>>
>>> I don't think we should call git-clean unconditionally -- imagine
>>> someone knew for sure they only needed to build part of the tools or the
>>> hypervisor.
>>
>> If you are worried about this you should check that there are no
>> uncommitted files before starting.
> 
> This is already done in this version.
> 
> I don't worry if there is uncommitted file, I just don't want to stop
> developers from being smarter than the script when they know git-clean
> is not necessary.

What kind of "smarter" did you have in mind?

This script sounds like an aid to developers who don't have the
motivation / experience / whatever to write their own script (or do
something fancier, like git rebase --exec).  If people want to be
smarter they can write their own script, using this as a starting point.

FWIW in xsatool I use 'git clean' extensively.

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel