Re: [Xen-devel] [PATCH for-next 6/9] kconfig: add llvm coverage option

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 26/10/17 10:19, Roger Pau Monne wrote:
> diff --git a/xen/common/coverage/Makefile b/xen/common/coverage/Makefile
> index 0e0510679e..e4541a1233 100644
> --- a/xen/common/coverage/Makefile
> +++ b/xen/common/coverage/Makefile
> @@ -1,3 +1,4 @@
> +ifeq ($(CONFIG_GCOV),y)
>  obj-y += gcov_base.o gcov.o coverage.o
>  obj-$(CONFIG_GCOV_FORMAT_3_4) += gcc_3_4.o
>  obj-$(CONFIG_GCOV_FORMAT_4_7) += gcc_4_7.o
> @@ -9,3 +10,6 @@ obj-$(CONFIG_GCOV_FORMAT_AUTODETECT) += $(call 
> cc-ifversion,lt,0x040700, \
>                                               gcc_4_7.o, $(call 
> cc-ifversion,lt,0x050000, \
>                                               gcc_4_9.o, $(call 
> cc-ifversion,lt,0x070000, \
>                                               gcc_5.o, gcc_7.o))))
> +else
> +obj-y += coverage.o
> +endif

How about

obj-y += coverage.o

ifeq ($(CONFIG_GCOV),y)
...
endif

seeing as coverage.o is common now?

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel