Re: [Xen-devel] [PATCH V3 8/29] tools/libxl: create vIOMMU during domain construction

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Oct 19, 2017 at 11:13:57AM +0100, Roger Pau Monné wrote:
> > +
> > +            if (viommu->type == LIBXL_VIOMMU_TYPE_INTEL_VTD) {
> > +                ret = xc_viommu_create(ctx->xch, domid, 
> > VIOMMU_TYPE_INTEL_VTD,
> > +                                       viommu->base_addr, viommu->cap, 
> > &id);
> 
> As said in another patch: this will break compilation because
> xc_viommu_create is introduced in patch 9.
> 
> Please organize the patches in a way that the code always compiles and
> works fine. Keep in mind that the Xen tree should be bisectable
> always.
> 

+10 to this.

We rely heavily on our test system's bisector to tell us what is wrong.
The bisector works on patch level. Please make sure every patch builds,
otherwise the test system will just give up.

If triaging can be done automatically by computers, maintainers can
spend less time doing tedious work and more time reviewing patches
(yours included).

Normally I use git-rebase to build every commit, but I figured that's a
bit too dangerous so I wrote a script.

Please check out:

  [PATCH v3 for-4.10] scripts: introduce a script for build test

It is still under review, but you can fish out some of the runes to do
build tests.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel