Re: [Xen-devel] [RFC XEN PATCH v3 02/39] x86_64/mm: drop redundant MFN to page conventions in cleanup_frame_table()

[Chao Peng <chao.p.peng@xxxxxxxxxxxxxxx>]

On Mon, 2017-09-11 at 12:37 +0800, Haozhong Zhang wrote:
> Replace pdx_to_page(pfn_to_pdx(pfn)) by mfn_to_page(pfn), which is
> identical to the former.

Looks good to me.

Chao
> 
> Signed-off-by: Haozhong Zhang <haozhong.zhang@xxxxxxxxx>
> ---
> Cc: Jan Beulich <jbeulich@xxxxxxxx>
> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
>  xen/arch/x86/x86_64/mm.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/xen/arch/x86/x86_64/mm.c b/xen/arch/x86/x86_64/mm.c
> index 6c5221f90c..c93383d7d9 100644
> --- a/xen/arch/x86/x86_64/mm.c
> +++ b/xen/arch/x86/x86_64/mm.c
> @@ -720,12 +720,11 @@ static void cleanup_frame_table(struct
> mem_hotadd_info *info)
>      spfn = info->spfn;
>      epfn = info->epfn;
>  
> -    sva = (unsigned long)pdx_to_page(pfn_to_pdx(spfn));
> -    eva = (unsigned long)pdx_to_page(pfn_to_pdx(epfn));
> +    sva = (unsigned long)mfn_to_page(spfn);
> +    eva = (unsigned long)mfn_to_page(epfn);
>  
>      /* Intialize all page */
> -    memset(mfn_to_page(spfn), -1,
> -           (unsigned long)mfn_to_page(epfn) - (unsigned
> long)mfn_to_page(spfn));
> +    memset((void *)sva, -1, eva - sva);
>  
>      while (sva < eva)
>      {

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel