[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 1/2] x86/boot: fix early error display



On 10/27/17 1:37 AM, Jan Beulich wrote:
>>>> On 26.10.17 at 23:05, <cardoe@xxxxxxxxxx> wrote:
>> On 10/18/17 4:50 AM, Jan Beulich wrote:
>>>>>> On 17.10.17 at 23:41, <cardoe@xxxxxxxxxx> wrote:
>>>> From: David Esler <drumandstrum@xxxxxxxxx>
>>>>
>>>> In 9180f5365524 a change was made to the send_chr function to take in
>>>> C-strings and print out a character at a time until a NULL was
>>>> encountered. However there is no code to increment the current character
>>>> position resulting in an endless loop of the first character. This adds
>>>> a simple increment.
>>>
>>> This description is not accurate (it should have changed together with
>>> the change to how you fix the issue) - with VGA the increment does
>>> happen. Hence "display" in the title is perhaps also at least misleading.
>>> I would be fine to adjust both while committing (and then adding my
>>> R-b), but feel free to propose an alternative.
>>
>> Jan,
>>
>> Can you queue this for 4.9 as well? That's where we ran into the issue
>> in the first place.
> 
> That how I did understand it, so I've queued this already, but for
> it to become eligible to applying to 4.9 it first needs to pass the
> push gate on master.
> 
> Jan
> 

Of course. I didn't mean to imply this should jump any existing process.
I had just realized that I didn't explicitly mention versions in my
original email and I just wanted to make sure I was explicit instead of
assuming.

Thanks again.
-- 
Doug Goldstein

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.