Re: [Xen-devel] [RFC XEN PATCH v3 09/39] xen/pmem: add framework for hypercall XEN_SYSCTL_nvdimm_op

[Chao Peng <chao.p.peng@xxxxxxxxxxxxxxx>]

> +/*
> + * Interface for NVDIMM management.
> + */
> +
> +struct xen_sysctl_nvdimm_op {
> +    uint32_t cmd; /* IN: XEN_SYSCTL_nvdimm_*; none is implemented
> yet. */
> +    uint32_t pad; /* IN: Always zero. */

If alignment is the only concern, then err can be moved to here.

If it's designed for future and does not get used now, then it's better
to check its value explicitly.

Chao

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel