Re: [Xen-devel] [PATCH 04/12] ARM: VGIC: move gic_remove_irq_from_queues()

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Fri, 10 Nov 2017, Andre Przywara wrote:
> Hi,
> 
> ...
> 
> >> diff --git a/xen/include/asm-arm/vgic.h b/xen/include/asm-arm/vgic.h
> >> index e489d0bf21..8d0ff65708 100644
> >> --- a/xen/include/asm-arm/vgic.h
> >> +++ b/xen/include/asm-arm/vgic.h
> >> @@ -204,6 +204,7 @@ extern int vcpu_vgic_init(struct vcpu *v);
> >>  extern struct vcpu *vgic_get_target_vcpu(struct vcpu *v, unsigned int 
> >> virq);
> >>  extern void vgic_vcpu_inject_irq(struct vcpu *v, unsigned int virq);
> >>  extern void vgic_vcpu_inject_spi(struct domain *d, unsigned int virq);
> >> +void vgic_remove_irq_from_queues(struct vcpu *v, struct pending_irq *p);
> > 
> > cosmetic: you might as well add an extern
> 
> I was wondering about that. I think extern in front of a prototype in a
> header file is a bit pointless. Linux mostly doesn't use it (apart from
> fs/ and some parts of security/).
> Though I can of course easily add it.

It was just to stay consistent. It's fine also to remove all the useless
extern keywords from this header.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel