Re: [Xen-devel] [PATCH] x86/HVM: fix interaction between internal and extern emulation

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 28.11.17 at 11:22, <Paul.Durrant@xxxxxxxxxx> wrote:
> It would definitely be good to only reset io_completion when it is clear 
> that handle_hvm_io_completion() is not going to be called (i.e. for 
> internally handled I/O)

Where would you suggest to do that? These two ...

> and perhaps even add ASSERTs in _hvm_emulate_one() 
> and handle_pio().

... sit down the call tree from handle_hvm_io_completion(). Plus
internal vs external isn't distinguishable in _hvm_emulate_one()
afaict (neither on the way in nor on the way out). Adding
ASSERT()s there suggests the distinction would need to be done
up the call stack, yet up the call stack may only be the VM exit
handler. I don't think the state reset should be done in vendor-
specific code.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel