Re: [Xen-devel] [PATCH] x86/setup: do not relocate below the end of current Xen image placement

[Daniel Kiper <daniel.kiper@xxxxxxxxxx>]

On Tue, Nov 28, 2017 at 04:51:51AM -0700, Jan Beulich wrote:
> >>> On 28.11.17 at 12:32, <daniel.kiper@xxxxxxxxxx> wrote:
> > I have a feeling that you can trigger this also when xen.efi
> > is launched directly from EFI. However, this may require some
> > fiddling with crashkernel values.
>
> I don't think so, no - that case was specifically fixed already
> (I've pointed at that commit in another sub-thread).

Ugh... Right, it looks that I misread the patch. Anyway, it seems to
me that is easy to fix. We should change line xen/arch/x86/setup.c:907

if ( efi_enabled(EFI_LOADER) )

to

if ( !xen_phys_start )

Then all cases should be covered. If you are OK with that I can
prepare a patch.

Daniel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel