Re: [Xen-devel] [PATCH] arm64: ITS: fix cacheability adjustment

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 11/28/2017 02:05 PM, Andre Przywara wrote:
> Hi,
Hi Andre,

Sorry someone I skipped that patch :/.

> On 16/11/17 12:02, Andre Przywara wrote:
> > If the host GICv3 redistributor reports that the pending table cannot
> > use shareable memory, we try to drop the cacheability attributes as
> > well. However we fail horribly in doing computer science 101 bit
> > masking, effectively clearing the whole register instead of just a few
> > bits.
> > Fix this by removing the one redundant masking operation and adding the
> > magic negation for the actually needed other operation.
> >
> > Reported-by: Manish Jaggi <manish.jaggi@xxxxxxxxxx>
> Manish, can you please test this patch and confirm that it works?
> Also how does the bug manifest for you?
>
> Julien, Stefano: Are there any objections against taking this patch for > 4.10? 
> This was introduced with the ITS emulation.
Reviewed-by: Julien Grall <julien.grall@xxxxxxxxxx>

This is new code and in technical preview. So I think it is fine to get 
them in Xen 4.10.
Release-Acked-by: Julien Grall <julien.grall@xxxxxxxxxx>

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel