[Xen-devel] Ping: [PATCH 4/3] x86: don't ignore foreigndom on L2/L3/L4 page table updates

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 12.10.17 at 14:24,  wrote:
> Silently assuming DOMID_SELF is unlikely to be a good idea for page
> table updates. For PGT_writable pages, though, it seems better to allow
> the writes, so the same check isn't being applied there.
> 
> Also add blank lines between the individual case blocks.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Ping?

> --- a/xen/arch/x86/mm.c
> +++ b/xen/arch/x86/mm.c
> @@ -3542,18 +3542,28 @@ long do_mmu_update(
>                                        cmd == MMU_PT_UPDATE_PRESERVE_AD, v,
>                                        pg_owner);
>                      break;
> +
>                  case PGT_l2_page_table:
> +                    if ( unlikely(pg_owner != pt_owner) )
> +                        break;
>                      rc = mod_l2_entry(va, l2e_from_intpte(req.val), mfn,
>                                        cmd == MMU_PT_UPDATE_PRESERVE_AD, v);
>                      break;
> +
>                  case PGT_l3_page_table:
> +                    if ( unlikely(pg_owner != pt_owner) )
> +                        break;
>                      rc = mod_l3_entry(va, l3e_from_intpte(req.val), mfn,
>                                        cmd == MMU_PT_UPDATE_PRESERVE_AD, v);
>                      break;
> +
>                  case PGT_l4_page_table:
> +                    if ( unlikely(pg_owner != pt_owner) )
> +                        break;
>                      rc = mod_l4_entry(va, l4e_from_intpte(req.val), mfn,
>                                        cmd == MMU_PT_UPDATE_PRESERVE_AD, v);
>                      break;
> +
>                  case PGT_writable_page:
>                      perfc_incr(writable_mmu_updates);
>                      if ( paging_write_guest_entry(v, va, req.val, 
> _mfn(mfn)) )
> 
> 
> 




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel