Re: [Xen-devel] [PATCH 2/5] x86: remove _PAGE_PSE check from get_page_from_l2e()

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 04/12/17 10:44, Jan Beulich wrote:
> With L2_DISALLOW_MASK containing _PAGE_PSE unconditionally as of commit
> 56fff3e5e9 ("x86: nuke PV superpage option and code") there's no point
> anymore in separately checking for the bit.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> --- a/xen/arch/x86/mm.c
> +++ b/xen/arch/x86/mm.c
> @@ -1106,15 +1106,10 @@ get_page_from_l2e(
>          return -EINVAL;
>      }
>  
> -    if ( !(l2e_get_flags(l2e) & _PAGE_PSE) )
> -    {
> -        rc = get_page_and_type_from_mfn(_mfn(mfn), PGT_l1_page_table, d, 0, 
> 0);
> -        if ( unlikely(rc == -EINVAL) && get_l2_linear_pagetable(l2e, pfn, d) 
> )
> -            rc = 0;
> -        return rc;
> -    }
> -
> -    return -EINVAL;
> +    rc = get_page_and_type_from_mfn(_mfn(mfn), PGT_l1_page_table, d, 0, 0);
> +    if ( unlikely(rc == -EINVAL) && get_l2_linear_pagetable(l2e, pfn, d) )
> +        rc = 0;

Newline here.  Otherwise, Reviewed-by: Andrew Cooper
<andrew.cooper3@xxxxxxxxxx>

> +    return rc;
>  }
>  
>  
>
>
>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel