[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Ping#3: [PATCH v3] x86/HVM: don't #GP/#SS on wrapping virt->linear translations

On 04/12/17 10:16, Jan Beulich wrote:
>>>> On 25.08.17 at 16:59,  wrote:
>>>>> On 10.08.17 at 09:19, <JBeulich@xxxxxxxx> wrote:
>>>>>> On 10.07.17 at 12:39, <JBeulich@xxxxxxxx> wrote:
>>>> Real hardware wraps silently in most cases, so we should behave the
>>>> same. Also split real and VM86 mode handling, as the latter really
>>>> ought to have limit checks applied.
>>>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>>>> ---
>>>> v3: Restore 32-bit wrap check for AMD.
>>>> v2: Extend to non-64-bit modes. Reduce 64-bit check to a single
>>>>     is_canonical_address() invocation.
> Same here - I think I've been carrying this for long enough.

I'm not sure what to say.  I'm not comfortable taking this change
without a regression test in place, which also serves to demonstrate the
correctness of the change.

Its simply a matter of time, not any other objection to the change.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.