[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 3/5] x86: improve _put_page_type() readability



>>> On 04.12.17 at 16:28, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 04/12/17 10:45, Jan Beulich wrote:
>> @@ -2477,10 +2478,9 @@ static int _put_page_type(struct page_in
>>                      continue;
>>                  /* We cleared the 'valid bit' so we do the clean up. */
>>                  rc = _put_final_page_type(page, x, preemptible, ptpg);
>> -                ptpg = NULL;
>>                  if ( x & PGT_partial )
>>                      put_page(page);
>> -                break;
> 
> Newline here.

Hmm, I've added one because I don't really mind, but this isn't the
main return point of the function.

>  Otherwise, Reviewed-by: Andrew Cooper
> <andrew.cooper3@xxxxxxxxx>

Thanks, Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.