[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [RFC v3 2/4] xen/linux_compat: Add a Linux compat header

Hi Jan,

On 05/12/17 09:20, Jan Beulich wrote:
On 05.12.17 at 04:59, <sgoel@xxxxxxxxxxxxxx> wrote:
For porting files from Linux it is useful to have a Linux API to Xen API
mapping header at a common location.

Looking at what you add here I really think "no, please don't". But
let's see what other maintainers thinks.

Most of those helpers are necessary when bringing non-modified from Linux.

We already have some drivers providing their own wrapper (e.g SMMUv2) and I would expect more in the future. Actually there are another series in the ML adding similar wrappers (see [1]).

So I think this is the right time to think about a common helpers. This will avoid duplication and make easier port. However, I don't agree with all the wrappers set in this file. I will comment on the patch.


[1] https://lists.xenproject.org/archives/html/xen-devel/2017-11/msg00666.html

Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.