Re: [Xen-devel] [OSSTEST RFC 05/16] TestSupport: Adapt target_https_mitm_proxy_setup to CentOS

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Anthony PERARD writes ("[OSSTEST RFC 05/16] TestSupport: Adapt 
target_https_mitm_proxy_setup to CentOS"):
> The location for new certificates is different, and
> update-ca-certificates is Debian specific.
...
> +    my $dest;
> +    my $update_ca_cmd;
> +    if ($ho->{OS} eq "centos" ) {

I'm not sure "centos" is the right key here.  Maybe we need
   is_host_redhat_derived($ho)
?

> +        $dest = '/etc/pki/ca-trust/source/anchors';
> +        $update_ca_cmd = 'update-ca-trust extract';
> +    } else {
> +        $dest = '/usr/local/share/ca-certificates';
> +        $update_ca_cmd = 'update-ca-certificates';
> +    }
>      target_putfilecontents_root_stash($ho,30,$cert,
> -                  '/usr/local/share/ca-certificates/osstest.crt');
> -    target_cmd_root($ho, 'update-ca-certificates', 300);
> +        $dest.'/osstest.crt');
> +    target_cmd_root($ho, $update_ca_cmd, 300);

But the general approach is right.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel