[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen/arm: gic-v3: Bail out if gicv3_cpu_init fail

Hi Stefano,

On 07/12/17 23:05, Stefano Stabellini wrote:
On Wed, 6 Dec 2017, Julien Grall wrote:
From: Julien Grall <julien.grall@xxxxxxx>

When system registers are not enabled, all the access to them will trap
                                              ^ accesses

in EL2. In Xen, system registers will be enabled by gicv3_cpu_init only
on success. As the rest of the code (e.g gicv3_hyp_init) relies on
system register, it is better to bail out directly.

This will save time on debugging early boot issue on GICv3 platform.

Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>

This is good:

Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>

Do we also want to print a warning or an error message?

AFAICT, all the path that return an error in gicv3_cpu_init (and the callers) have already a warning/error message. So no need to add an extra one here.


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.