Re: [Xen-devel] [PATCH v8] x86/altp2m: support for setting restrictions for an array of pages

[George Dunlap <dunlapg@xxxxxxxxx>]

On Tue, Oct 24, 2017 at 11:19 AM, Petre Pircalabu
<ppircalabu@xxxxxxxxxxxxxxx> wrote:
> From: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
>
> For the default EPT view we have xc_set_mem_access_multi(), which
> is able to set an array of pages to an array of access rights with
> a single hypercall. However, this functionality was lacking for the
> altp2m subsystem, which could only set page restrictions for one
> page at a time. This patch addresses the gap.
>
> HVMOP_altp2m_set_mem_access_multi has been added as a HVMOP (as opposed to a
> DOMCTL) for consistency with its HVMOP_altp2m_set_mem_access counterpart (and
> hence with the original altp2m design, where domains are allowed - with the
> proper altp2m access rights - to alter these settings), in the absence of an
> official position on the issue from the original altp2m designers.
>
> Signed-off-by: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
> Signed-off-by: Petre Pircalabu <ppircalabu@xxxxxxxxxxxxxxx>

FWIW the approach looks good to me here.

You mainly need an x86 maintainer's ack and a toolstack maintainer's
ack (of which I am neither).

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel