Re: [Xen-devel] [PATCH] xen/efi: Fix build with clang-5.0

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Wed, 13 Dec 2017, Andrew Cooper wrote:
> The clang-5.0 build is reliably failing with:
> 
>   Error: size of boot.o:.text is 0x01
> 
> which is because efi_arch_flush_dcache_area() exists as a single ret
> instruction.  Mark it as __init like everything else in the files.
> 
> Spotted by Travis.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>


> ---
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> CC: Julien Grall <julien.grall@xxxxxxx>
> 
> For future discussion, Why are these implementations not inline?  Why are we
> being special and allowing a header file and define functions and globals like
> this?
> ---
>  xen/arch/arm/efi/efi-boot.h | 2 +-
>  xen/arch/x86/efi/efi-boot.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
> index 56de26e..ca655ff 100644
> --- a/xen/arch/arm/efi/efi-boot.h
> +++ b/xen/arch/arm/efi/efi-boot.h
> @@ -597,7 +597,7 @@ static void __init 
> efi_arch_video_init(EFI_GRAPHICS_OUTPUT_PROTOCOL *gop,
>  {
>  }
>  
> -static void efi_arch_flush_dcache_area(const void *vaddr, UINTN size)
> +static void __init efi_arch_flush_dcache_area(const void *vaddr, UINTN size)
>  {
>      __flush_dcache_area(vaddr, size);
>  }
> diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h
> index 8d295ff..d30f688 100644
> --- a/xen/arch/x86/efi/efi-boot.h
> +++ b/xen/arch/x86/efi/efi-boot.h
> @@ -668,7 +668,7 @@ static bool __init 
> efi_arch_use_config_file(EFI_SYSTEM_TABLE *SystemTable)
>      return true; /* x86 always uses a config file */
>  }
>  
> -static void efi_arch_flush_dcache_area(const void *vaddr, UINTN size) { }
> +static void __init efi_arch_flush_dcache_area(const void *vaddr, UINTN size) 
> { }
>  
>  void __init efi_multiboot2(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE 
> *SystemTable)
>  {
> -- 
> 2.1.4
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel