Re: [Xen-devel] [PATCH v7 for-next 06/12] pci: split code to size BARs from pci_add_device

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 18.10.17 at 13:40, <roger.pau@xxxxxxxxxx> wrote:
> +                ret = pci_size_mem_bar(sbdf, idx, NULL, &pdev->vf_rlen[i],
> +                                       PCI_BAR_VF |
> +                                       (i == PCI_SRIOV_NUM_BARS - 1) ?
> +                                       PCI_BAR_LAST : 0);

There are parentheses missing around the conditional expression
here.

> +                if ( ret < 0 )
> +                    break;

I don't think you should bail out here, or report the error you've
got back to your caller. Otherwise this is latent (for the former)
and actual (for the latter) change in behavior.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel