Re: [Xen-devel] [RFC v3 4/4] xen/iommu: smmu-v3: Add Xen specific code to enable the ported driver

["Goel, Sameer" <sgoel@xxxxxxxxxxxxxx>]

On 12/5/2017 7:17 AM, Julien Grall wrote:
> Hello,
> 
> On 05/12/17 03:59, Sameer Goel wrote:
>> This driver follows an approach similar to smmu driver. The intent here
>> is to reuse as much Linux code as possible.
>> - Glue code has been introduced in headers to bridge the API calls.
>> - Called Linux functions from the Xen IOMMU function calls.
>> - Xen modifications are preceded by /*Xen: comment */
>> - New config items for SMMUv3 and legacy SMMU have been defined.
> 
> There are no reason to touch legacy SMMU in this patch. Please move that 
> outside of it.

Do you want me to remove the config item for Legacy SMMU?
> 
>>
>> Signed-off-by: Sameer Goel <sgoel@xxxxxxxxxxxxxx>
>> ---
>>   xen/drivers/Kconfig                    |   2 +
>>   xen/drivers/passthrough/arm/Kconfig    |  14 +
>>   xen/drivers/passthrough/arm/Makefile   |   3 +-
>>   xen/drivers/passthrough/arm/arm_smmu.h | 189 ++++++++++
>>   xen/drivers/passthrough/arm/smmu-v3.c  | 619 
>> ++++++++++++++++++++++++++++++---
>>   5 files changed, 768 insertions(+), 59 deletions(-)
>>   create mode 100644 xen/drivers/passthrough/arm/Kconfig
>>   create mode 100644 xen/drivers/passthrough/arm/arm_smmu.h
>>
>> diff --git a/xen/drivers/Kconfig b/xen/drivers/Kconfig
>> index bc3a54f..6126553 100644
>> --- a/xen/drivers/Kconfig
>> +++ b/xen/drivers/Kconfig
>> @@ -12,4 +12,6 @@ source "drivers/pci/Kconfig"
>>     source "drivers/video/Kconfig"
>>   +source "drivers/passthrough/arm/Kconfig"
>> +
>>   endmenu
>> diff --git a/xen/drivers/passthrough/arm/Kconfig 
>> b/xen/drivers/passthrough/arm/Kconfig
>> new file mode 100644
>> index 0000000..9ac4cea
>> --- /dev/null
>> +++ b/xen/drivers/passthrough/arm/Kconfig
>> @@ -0,0 +1,14 @@
>> +
>> +config ARM_SMMU
>> +    bool "ARM SMMU v1/2 support"
>> +    depends on ARM_64
> 
> Why? SMMUv1 and SMMUv2 supports Arm 32-bit.
> 
>> +    help
>> +     Support for implementations of the ARM System MMU architecture. (1/2)
> 
> I am not sure to understand the (1/2) after the final point.
> 
>> +
>> +config ARM_SMMU_v3
>> +    bool "ARM SMMUv3 Support"
>> +    depends on ARM_64
>> +    help
>> +     Support for implementations of the ARM System MMU architecture
>> +     version 3.
>> +

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel