[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH] x86/mcheck: Drop unnecessary barriers



spin_unlock() has full barrier semantics already.

Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
---
CC: Jan Beulich <JBeulich@xxxxxxxx>
---
 xen/arch/x86/cpu/mcheck/mctelem.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/xen/arch/x86/cpu/mcheck/mctelem.c 
b/xen/arch/x86/cpu/mcheck/mctelem.c
index 492e2af..35431df 100644
--- a/xen/arch/x86/cpu/mcheck/mctelem.c
+++ b/xen/arch/x86/cpu/mcheck/mctelem.c
@@ -520,7 +520,6 @@ mctelem_cookie_t 
mctelem_consume_oldest_begin(mctelem_class_t which)
        }
 
        mctelem_processing_hold(tep);
-       wmb();
        spin_unlock(&processing_lock);
        return MCTE2COOKIE(tep);
 }
@@ -531,7 +530,6 @@ void mctelem_consume_oldest_end(mctelem_cookie_t cookie)
 
        spin_lock(&processing_lock);
        mctelem_processing_release(tep);
-       wmb();
        spin_unlock(&processing_lock);
 }
 
@@ -547,7 +545,6 @@ void mctelem_ack(mctelem_class_t which, mctelem_cookie_t 
cookie)
        spin_lock(&processing_lock);
        if (tep == mctctl.mctc_processing_head[target])
                mctelem_processing_release(tep);
-       wmb();
        spin_unlock(&processing_lock);
 }
 
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.