[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Question about PV normalise_pagetable

On 23/12/17 13:35, Bruno Alvisio wrote:
> Hi all,
> I was understanding the code in tools/libxc/xc_sr_save_x86_pv.c and
> found this comment to the normalise_pagetable:
> /*
> * Normalise a pagetable for the migration stream. Performs pfn->mfn
> * conversions on the ptes.
> */
> static int normalise_pagetable(struct xc_sr_context *ctx, const uint64_t
> *src,
> uint64_t *dst, unsigned long type)
> Looks like the function (as it should) is doing the reverse conversion
> mfn->pfn.
> Wanted to confirm this typo or if I am missing something?

Yup.  This is a typo - well spotted!  (Probably too much copy&paste
during the 3 or 4 times I reworked the callbacks interface.)

I'll see about fixing this in due course.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.