Re: [Xen-devel] [PATCH v2] x86/upcall: inject a spurious event after setting upcall vector

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.01.18 at 13:11, <roger.pau@xxxxxxxxxx> wrote:
> In case the vCPU has pending events to inject. This fixes a bug that
> happened if the guest mapped the vcpu info area using
> VCPUOP_register_vcpu_info without having setup the event channel
> upcall, and then setup the upcall vector.
> 
> In this scenario the guest would not receive any upcalls, because the
> call to VCPUOP_register_vcpu_info would have marked the vCPU as having
> pending events, but the vector could not be injected because it was
> not yet setup.
> 
> This has not caused issues so far because all the consumers first
> setup the vector callback and then map the vcpu info page, but there's
> no limitation that prevents doing it in the inverse order.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Despite my small concern
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel