Re: [Xen-devel] [PATCH RFC v1 29/74] x86: xen pv clock time source

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.01.18 at 14:05, <wei.liu2@xxxxxxxxxx> wrote:
> It is a variant of TSC clock source.
> 
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Mostly fine, with the TODO addressed, u64 etc replaced by uint64_t
etc, ...

> +static always_inline
> +u64 __read_cycle(const struct vcpu_time_info *info, u64 tsc)

... the double underscores dropped here, and ...

> +static u64 last_value;

... this moved into the only function it's needed in.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel