Re: [Xen-devel] [PATCH RFC v1 36/74] --- x86/shim: Kconfig and command line options

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.01.18 at 14:05, <wei.liu2@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/Kconfig
> +++ b/xen/arch/x86/Kconfig
> @@ -133,6 +133,28 @@ config PVH_GUEST
>       ---help---
>         Support booting using the PVH ABI.
>  
> +       If unsure, say N.
> +
> +config PV_SHIM
> +     def_bool n
> +     prompt "PV Shim"
> +     depends on PV && XEN_GUEST
> +     ---help---
> +       Build Xen with a mode which acts as a shim to allow PV guest to run
> +       in an HVM/PVH container. This mode can only be enabled with command
> +       line option.
> +
> +       If unsure, say N.
> +
> +config PV_SHIM_EXCLUSIVE
> +     def_bool n
> +     prompt "PV Shim Exclusive"
> +     depends on PV_SHIM

My expectation so far was that this would be the only mode we
target, hence I think at the very least the default wants to be y
here.

> --- /dev/null
> +++ b/xen/arch/x86/pv/shim.c
> @@ -0,0 +1,39 @@
> +/******************************************************************************
> + * arch/x86/pv/shim.c
> + *
> + * Functionaltiy for PV Shim mode
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; If not, see <http://www.gnu.org/licenses/>.
> + *
> + * Copyright (c) 2017 Citrix Systems Ltd.
> + */
> +#include <xen/init.h>
> +#include <xen/types.h>
> +
> +#include <asm/apic.h>
> +
> +#ifndef CONFIG_PV_SHIM_EXCLUSIVE
> +bool pv_shim;

__read_mostly (if not __initdata)?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel