Re: [Xen-devel] [PATCH RFC v1 20/74] x86: produce a binary that can be booted as PVH

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.01.18 at 16:59, <wei.liu2@xxxxxxxxxx> wrote:
> On Fri, Jan 05, 2018 at 04:39:33AM -0700, Jan Beulich wrote:
>> >>> On 04.01.18 at 14:05, <wei.liu2@xxxxxxxxxx> wrote:
>> > --- a/xen/arch/x86/Makefile
>> > +++ b/xen/arch/x86/Makefile
>> > @@ -75,6 +75,8 @@ efi-y := $(shell if [ ! -r 
>> > $(BASEDIR)/include/xen/compile.h -o \
>> >                        -O $(BASEDIR)/include/xen/compile.h ]; then \
>> >                           echo '$(TARGET).efi'; fi)
>> >  
>> > +shim-$(CONFIG_PVH_GUEST) := $(TARGET)-shim
>> > +
>> >  ifneq ($(build_id_linker),)
>> >  notes_phdrs = --notes
>> >  else
>> > @@ -93,7 +95,7 @@ endif
>> >  syms-warn-dup-y := --warn-dup
>> >  syms-warn-dup-$(CONFIG_SUPPRESS_DUPLICATE_SYMBOL_WARNINGS) :=
>> >  
>> > -$(TARGET): $(TARGET)-syms $(efi-y) boot/mkelf32
>> > +$(TARGET): $(TARGET)-syms $(efi-y) boot/mkelf32 $(shim-y)
>> >    ./boot/mkelf32 $(notes_phdrs) $(TARGET)-syms $(TARGET) 
>> > $(XEN_IMG_OFFSET) \
>> >                   `$(NM) $(TARGET)-syms | sed -ne 's/^\([^ ]*\) . 
>> > __2M_rwdata_end$$/0x\1/p'`
>> 
>> Hmm, so you mean to build shim and "normal" Xen at the same time,
>> with all the same objects? That's rather unexpected following the
>> earlier exchange Andrew and I had. I would expect the shim to not
>> require quite a few bits and pieces, and hence wanting to be built
>> independently.
>> 
> 
> There is a later patch in this series to link xen under tools/firmware/
> to build the shim there, which would need build system patch like this.
> 
> The can be cleaned up somehow. At the time I wasn't sure how best to
> proceed (and certainly didn't take part in the discussion between Andrew
> and you).
> 
> Suggestions welcome.

Well, when I had discussed this with Andrew, my view on the
outcome was that we'd build either xen-shim or the pair of
xen.gz and xen.efi in a single build invocation (hence two build
all three, a second make would be needed, which would seem
to be at least along the lines of what that later patch is doing).

The above dependency, otoh, suggests that you want to
build both xen.gz and xen-shim.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel