Re: [Xen-devel] [PATCH RFC v1 54/74] xen/pvshim: set correct domid value

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Mon, Jan 08, 2018 at 07:17:16AM -0700, Jan Beulich wrote:
> >>> On 04.01.18 at 14:06, <wei.liu2@xxxxxxxxxx> wrote:
> > @@ -576,11 +578,11 @@ static void noinline init_done(void)
> >  
> >      system_state = SYS_STATE_active;
> >  
> > +    domain_unpause_by_systemcontroller(dom0);
> > +
> >      /* MUST be done prior to removing .init data. */
> >      unregister_init_virtual_region();
> >  
> > -    domain_unpause_by_systemcontroller(hardware_domain);
> 
> Why the re-ordering? Along the lines of the earlier comment,
> using "dom0" as replacement (static) variable isn't very nice.
> Please at least accompany its declaration by a comment.

The 'dom0' variable is in the .init section, so it seems best to do
the unpause first and then remove the init virtual regions.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel