Re: [Xen-devel] [PATCH v3 2/2] docs: note default for timer_mode in xl.cfg man

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Mon, Jan 15, 2018 at 09:24:52PM -0600, Doug Goldstein wrote:
> There was no default documented but inspecting
> libxl__domain_build_info_setdefault() shows the default to be
> LIBXL_TIMER_MODE_NO_DELAY_FOR_MISSED_TICKS.
> 
> Signed-off-by: Doug Goldstein <cardoe@xxxxxxxxxx>
> ---
> CC: Wei Liu <wei.liu2@xxxxxxxxxx>
> CC: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> # George for the 4.8 and 4.9 backport
> CC: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
> 
> change from v2:
> - Roger noted that the code differed from the
>   header that I used as the source of truth
> change from v1:
> - added same docs addition to HVM
> ---
>  docs/man/xl.cfg.pod.5.in | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/docs/man/xl.cfg.pod.5.in b/docs/man/xl.cfg.pod.5.in
> index b7b91d8627..6b3ee81602 100644
> --- a/docs/man/xl.cfg.pod.5.in
> +++ b/docs/man/xl.cfg.pod.5.in
> @@ -1889,7 +1889,7 @@ advance the vCPU's virtual time stepwise for each one.
>  
>  No delay for missed ticks. As above, missed interrupts are delivered,
>  but guest time always tracks wallclock (i.e., real) time while doing
> -so.
> +so. This is the default.
>  
>  =item B<no_missed_ticks_pending>
>  
> @@ -2348,13 +2348,14 @@ Specifies the mode for Virtual Timers. The valid 
> values are as follows:
>  Delay for missed ticks. Do not advance a vCPU's time beyond the
>  correct delivery time for interrupts that have been missed due to
>  preemption. Deliver missed interrupts when the vCPU is rescheduled and
> -advance the vCPU's virtual time stepwise for each one.
> +advance the vCPU's virtual time stepwise for each one. This is the
> +default.

The chunk above is now stale, since we agreed that
no_delay_for_missed_ticks was the default.

Thanks, Roger.

>  =item B<no_delay_for_missed_ticks>
>  
>  No delay for missed ticks. As above, missed interrupts are delivered,
>  but guest time always tracks wallclock (i.e., real) time while doing
> -so.
> +so. This is the default.
>  
>  =item B<no_missed_ticks_pending>
>  
> -- 
> 2.13.6
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel