Re: [Xen-devel] [PATCH v3 1/2] x86: Meltdown band-aid against malicious 64-bit PV guests

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 16/01/18 15:21, Jan Beulich wrote:
> --- a/xen/include/asm-x86/x86_64/page.h
> +++ b/xen/include/asm-x86/x86_64/page.h
> @@ -24,8 +24,8 @@
>  /* These are architectural limits. Current CPUs support only 40-bit phys. */
>  #define PADDR_BITS              52
>  #define VADDR_BITS              48
> -#define PADDR_MASK              ((1UL << PADDR_BITS)-1)
> -#define VADDR_MASK              ((1UL << VADDR_BITS)-1)
> +#define PADDR_MASK              ((_AC(1,UL) << PADDR_BITS)-1)
> +#define VADDR_MASK              ((_AC(1,UL) << VADDR_BITS)-1)

Sorry to only notice these now, but spaces as you're adjusting these.

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

>  
>  #define VADDR_TOP_BIT           (1UL << (VADDR_BITS - 1))
>  #define CANONICAL_MASK          (~0UL & ~VADDR_MASK)
>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel